This repository was archived by the owner on Apr 13, 2020. It is now read-only.
[HOUSEKEEPING] Resolved eslint errors/warning in deployment commands#452
Merged
dennisseah merged 1 commit intomasterfrom Mar 25, 2020
Merged
[HOUSEKEEPING] Resolved eslint errors/warning in deployment commands#452dennisseah merged 1 commit intomasterfrom
dennisseah merged 1 commit intomasterfrom
Conversation
dennisseah
requested review from
andrebriggs,
edaena,
evanlouie and
samiyaakhtar
evanlouie
approved these changes
Mar 25, 2020
samiyaakhtar
approved these changes
Mar 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to microsoft/bedrock#1157
mainly to address the
no-non-null-assertionruleleft out the get.ts and get.test.ts files because Samiya is making changes
reused the common validation functions to validate storage account and table name