This repository was archived by the owner on Apr 13, 2020. It is now read-only.
Merged
Conversation
Collaborator
Author
|
Investigating why tests are failing. Can't seem to make them fail locally. |
evanlouie
force-pushed
the
1084-default-ring-routing
branch
from
e13aeb9 to
f7399d0
Compare
edaena
approved these changes
Mar 20, 2020
evanlouie
force-pushed
the
1084-default-ring-routing
branch
from
f7399d0 to
7ed612d
Compare
Collaborator
|
Trying to follow the logic @evanlouie , what happens when we changed the default ring? will |
Collaborator
Author
|
@mtarng yup. |
evanlouie
force-pushed
the
1084-default-ring-routing
branch
3 times, most recently
from
cc2727c to
a699cf1
Compare
- When a ring is marked as `isDefault: true`, `spk hld reconcile` will now
generate an additional IngressRoute and Middleware.
- The IngressRoute will not have a `Ring` route match rule
- The IngressRoute points to the same backend service as its ringed
counterpart.
- Only one ring can be marked `isDefault: true` -- validation is run at
`spk hld reconcile` execute time, throwing an error if more than one
`isDefault`.
- Refactored IngressRoute tests
- Added compatibility configuration for eslint and prettier.
closes microsoft/bedrock#1084
evanlouie
force-pushed
the
1084-default-ring-routing
branch
from
a699cf1 to
c321f88
Compare
mtarng
approved these changes
Mar 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isDefault: true,spk hld reconcilewill nowgenerate an additional IngressRoute and Middleware.
Ringroute match rulecounterpart.
isDefault: true-- validation is run atspk hld reconcileexecute time, throwing an error if more than oneisDefault.closes microsoft/bedrock#1084