This repository was archived by the owner on Apr 13, 2020. It is now read-only.
Conversation
…commits if there are no changes
…ng PRs with no changes if there are no updates
mtarng
requested review from
bnookala,
edaena,
evanlouie,
sarath-p and
yradsmikham
bnookala
approved these changes
Mar 20, 2020
Member
bnookala
left a comment
bnookala
left a comment
There was a problem hiding this comment.
only thought is that im wondering if we should preserve indentation in logical statements, but otherwise lg2m
Collaborator
Author
|
@bnookala I thought about it, but because the script is stored in YAML, i'm afraid that may break the script/pipeline definition. |
edaena
approved these changes
Mar 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes microsoft/bedrock#1134
Additionally, added changes so if the lifecycle pipeline runs and there are no changes, it will no longer push a branch and open a PR with no file changes.
Also moved helm version to be a constant