This repository was archived by the owner on Apr 13, 2020. It is now read-only.
Changes to get build pipeline working in branch issue1113x#402
Merged
andrebriggs merged 2 commits intoissue1113xfrom Mar 16, 2020
Merged
Changes to get build pipeline working in branch issue1113x#402andrebriggs merged 2 commits intoissue1113xfrom
andrebriggs merged 2 commits intoissue1113xfrom
Conversation
dennisseah
approved these changes
Mar 16, 2020
dennisseah
reviewed
Mar 16, 2020
| `Azure container registry, ${name} already existed in subscription` | ||
| ); | ||
| return false; | ||
| return true; |
Collaborator
There was a problem hiding this comment.
this should be false because we want to indicate that the command does not create the ACR in the setup.log
dennisseah
added a commit
that referenced
this pull request
Mar 20, 2020
* [FEATURE] scaffold app and helm repo in spk setup command * [FEATURE] lifecycle and build pipeline in spk setup command * fix eslint error * fixed unit test * making acr name configurable that's not hardcode it * added code to check if acr name is between 5 and 50 chars long * Changes to get build pipeline working in branch issue1113x (#402) * Changes to get build pipeline working * Updated spelling * minor fixes * fix test * fix lint * fix tests * adding tests and prompt for subscriptionId before creating sp * rebase * fix eslint * Delete tslint.json * Update subscriptionService.test.ts * fixing labels and messages Co-authored-by: Andre Briggs <[email protected]> Co-authored-by: Nate <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.