This repository was archived by the owner on Apr 13, 2020. It is now read-only.
Merged
Conversation
edaena
requested review from
andrebriggs,
bnookala,
evanlouie,
mtarng and
yradsmikham
edaena
commented
Mar 11, 2020
mtarng
suggested changes
Mar 11, 2020
andrebriggs
reviewed
Mar 11, 2020
andrebriggs
reviewed
Mar 11, 2020
edaena
changed the title
edaena
changed the title
mtarng
approved these changes
Mar 19, 2020
Collaborator
mtarng
left a comment
mtarng
left a comment
There was a problem hiding this comment.
Approving. Looks like we're commenting it out because spk rings * is not live yet.
yradsmikham
approved these changes
Mar 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related task: Extend spk integration
Closes microsoft/bedrock#974