This repository was archived by the owner on Apr 13, 2020. It is now read-only.
[FEATURE] Create resource group and ACR in spk setup command#391
Merged
dennisseah merged 7 commits intomasterfrom Mar 12, 2020
Merged
[FEATURE] Create resource group and ACR in spk setup command#391dennisseah merged 7 commits intomasterfrom
dennisseah merged 7 commits intomasterfrom
Conversation
dennisseah
requested review from
andrebriggs,
edaena,
samiyaakhtar and
sarath-p
sarath-p
suggested changes
Mar 11, 2020
| @@ -0,0 +1,110 @@ | |||
| import { ContainerRegistryManagementClient } from "@azure/arm-containerregistry"; | |||
Contributor
There was a problem hiding this comment.
I would suggest moving this file to lib\azure folder since it supposed to have all .ts files related to azure .
| @@ -0,0 +1,125 @@ | |||
| import { | |||
Contributor
There was a problem hiding this comment.
Similar to above comment to move it to lib\azure folder.
sarath-p
approved these changes
Mar 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is needed before able to create app and helm repo
closes microsoft/bedrock#1145