Skip to content
This repository was archived by the owner on Apr 13, 2020. It is now read-only.

[FEATURE] create service principal in spk setup#379

Merged
dennisseah merged 9 commits intomasterfrom
issue1113sp
Mar 10, 2020
Merged

[FEATURE] create service principal in spk setup#379
dennisseah merged 9 commits intomasterfrom
issue1113sp

Conversation

@dennisseah
Copy link
Collaborator

related to microsoft/bedrock#1113

in order to scaffold a sample app, we need a service principal.
user has 2 options

  1. provide it (Id, password and Tenant Id)
  2. get command line to execute az command line tool to create it.

Copy link
Collaborator

@andrebriggs andrebriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dennisseah when manually entering the SP password the text is not hidden. Otherwise looks good!

@dennisseah
Copy link
Collaborator Author

@dennisseah when manually entering the SP password the text is not hidden. Otherwise looks good!

accept, thanks for testing it out

@dennisseah dennisseah requested a review from mtarng March 8, 2020 03:00
@andrebriggs andrebriggs self-requested a review March 9, 2020 14:36
await azCLILogin();
try {
logger.info("attempting to create service principal with az command line");
const result = await exec("az", ["ad", "sp", "create-for-rbac"]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in order to user the SDK, we need to authenticate and hence we need a service principal. So we need to create a service principal or ask user to enter service principal id, password and tenantId. Once this is done, we can start to use the SDK.

@dennisseah dennisseah merged commit 681cd29 into master Mar 10, 2020
@dennisseah dennisseah deleted the issue1113sp branch March 10, 2020 02:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants