This repository was archived by the owner on Apr 13, 2020. It is now read-only.
[FEATURE] spk setup command: added scaffold HLD and Manifest repos #358
Merged
dennisseah merged 20 commits intomasterfrom Mar 4, 2020
Merged
[FEATURE] spk setup command: added scaffold HLD and Manifest repos #358dennisseah merged 20 commits intomasterfrom
dennisseah merged 20 commits intomasterfrom
Conversation
1. added a request context object to capture all valid input values and status of execution (.e.g is project created, what are the repo created). 2. added `spk setup` as one of the commands. 3. added file operation supports for creating folder, change directory, etc. 4. added git operation supports 5. modified project service to have the right value for `templateTypeId` and `sourceControlType` 6. added scaffold operation supports 7. added code to create setup.log file main feature added: scaffold HLD and Manifest repos
edaena
reviewed
Mar 2, 2020
edaena
reviewed
Mar 2, 2020
andrebriggs
approved these changes
Mar 3, 2020
Collaborator
|
@dennisseah @andrebriggs the PR is pretty big and only "related to" the epic. Would be nice if we could break down the epic into smaller tasks and each PR would "close" a task from the epic? |
Collaborator
|
@dennisseah @andrebriggs Let's try and keep PRs smaller and manageable. |
Collaborator
|
@samiyaakhtar created microsoft/bedrock#1086 and associated with this PR |
mtarng
reviewed
Mar 4, 2020
mtarng
reviewed
Mar 4, 2020
| * | ||
| * @param absPath Absolute Path | ||
| */ | ||
| export const moveToAbsPath = (absPath: string) => { |
Collaborator
There was a problem hiding this comment.
Just commenting to say fsUtil could probably live in our general lib as could be shared by other commands too.
Collaborator
Author
There was a problem hiding this comment.
we can move it later if needed.
mtarng
reviewed
Mar 4, 2020
mtarng
approved these changes
Mar 4, 2020
Collaborator
mtarng
left a comment
mtarng
left a comment
There was a problem hiding this comment.
Minor comments. Looks good otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spk setupas one of the commands.templateTypeIdandsourceControlTypemain feature added: scaffold HLD and Manifest repos
closes microsoft/bedrock#1086
related to microsoft/bedrock#986