Skip to content

Conversation

@ymh199478
Copy link
Contributor

@ymh199478 ymh199478 commented Jul 27, 2019

Q A
Branch? v2.0(master)
Bug fix? No
New feature? No
Deprecations? No
Internal Changed? Yes
Removed No
Tests pass? Yes
Doc pr? No

This submission optimizes the variable naming, api and guarding of SortSet.cs

@ymh199478 ymh199478 changed the title Optimization SortSet Refactoring SortSet Jul 27, 2019
@ymh199478 ymh199478 mentioned this pull request Jul 27, 2019
55 tasks
@codecov-io
Copy link

codecov-io commented Jul 27, 2019

Codecov Report

Merging #265 into master will increase coverage by 0.07%.
The diff coverage is 92.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
+ Coverage   89.37%   89.44%   +0.07%     
==========================================
  Files          36       36              
  Lines        2410     2445      +35     
==========================================
+ Hits         2154     2187      +33     
- Misses        256      258       +2
Impacted Files Coverage Δ
src/CatLib.Core/Container/Container.cs 96.32% <100%> (-0.01%) ⬇️
src/CatLib.Core/Support/SortSet.cs 90.85% <92.68%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 228ebb6...764dd28. Read the comment docs.

@ymh199478 ymh199478 merged commit da2cb34 into master Jul 27, 2019
@ymh199478 ymh199478 deleted the changed/free-sortset branch July 27, 2019 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants