Replace mapfile usage for broader Bash compatibility#1497
Merged
Conversation
This was referenced Feb 22, 2026
|
Checks from Comment Test PR #1498 |
|
Checks from Request Change Test PR #1499 |
ff7c3bd to
da194b1
Compare
This was referenced Feb 22, 2026
|
Checks from Push Test PR #1505
|
|
Checks from Push as App Test PR #1502 |
|
Checks from Request Change Test PR #1504 |
|
Checks from Comment Test PR #1503 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
mapfile: command not found, which is caused by using the Bash-4+ builtinmapfileon runners that have older Bash (notably macOS Bash 3.2) or minimal shells.Description
mapfile -t TARGET_PATHS < <(printf '%s' "$TARGETS")with a portablewhile IFS= read -r TARGET_PATH || [[ -n "$TARGET_PATH" ]]loop that appends toTARGET_PATHS.mapfile -t CHANGED_FILES < <(git diff --name-only ... )with awhile IFS= read -r CHANGED_FILE || [[ -n "$CHANGED_FILE" ]]loop that fillsCHANGED_FILESfrom process substitution.TARGETSparsing change in thegit commitstep so both thegit-statusandgit-commitsteps no longer rely onmapfile.Testing
rg -n "mapfile" action.ymland confirmed there are no remainingmapfileusages (success).git diff --stat HEAD~1..HEADto verify the expected changes were produced toaction.yml(success).git status --shortand inspectedaction.ymlwithnl -ba action.yml | sed -n ...to validate the replacements are in the intended locations (success).Codex Task