Prevent deadlock when Windows Forms are loaded in the PowerShell process#3
Merged
CarloToso merged 1 commit intoCarloToso:encodinghelperfrom Jan 7, 2024
Conversation
This is needed to stop web methods from deadlocking when windows forms are loaded from within the PowerShell process.
Author
|
@CarloToso - hopefully this patch fixes the build failures. I wasn't aware this was an issue but found a patch by seeminglyscience that must have been found post-release of pwsh 7.4. The test included in that patch is what was failing/stalling the build process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Must use ConfigureAwait(false) on any awaited methods to prevent use of windows forms in the PowerShell process
from deadlocking the process. This was the cause of the CI failure - test was added specifically for this issue that causes the CI test to deadlock and time out the build stage.