Merged
Conversation
We need to set MACOSX_DEPLOYMENT_TARGET when building HDF5, explained here https://github.com/h5py/h5py/pull/2444/files#r1679541011
Member
Author
|
Linux ARM builds are failing due to pypa/cibuildwheel#1771. Just leaving this breadcrumb to sort out the fix. |
bryanwweber
force-pushed
the
add-hdf5
branch
2 times, most recently
from
8725750 to
9dbf040
Compare
…installation structure
The other platforms should use Ninja which is automatically parallel
speth
approved these changes
Jul 22, 2024
Member
speth
left a comment
speth
left a comment
There was a problem hiding this comment.
Thanks for getting this working, @bryanwweber! I had just one small comment below. I tested out the macOS arm64 package and didn't have any problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I plan to squash-merge this PR once its approved, so I don't plan to clean up the commit history. I don't think it's very interesting for all this CI nonsense anyways.