Build updates for Cantera 3.0 features#44
Merged
speth merged 22 commits intoCantera:mainfrom Jun 30, 2023
Merged
Conversation
5 tasks
bryanwweber
reviewed
Jun 22, 2023
| name: Matlab toolbox for ${{ matrix.os }} | ||
| runs-on: ${{ matrix.os }} | ||
| # Run this job even if post-pending-status was skipped | ||
| if: always() |
Member
There was a problem hiding this comment.
These should probably be success() || cancelled() so they don't run if the previous step actually failed.
Member
Author
There was a problem hiding this comment.
Is skipped the same as cancelled?
Even so, if the "post-pending-status" job fails, I think I'd still rather go ahead with the actual package build.
Member
There was a problem hiding this comment.
Yeah, I'm pretty sure that's the case. Anyways, your reasoning seems fine, it's good with me to keep it this way.
speth
force-pushed
the
native-hdf5
branch
4 times, most recently
from
a7a5f22 to
7d46197
Compare
No existing files rely on this, and I think this is slowing down the builds a lot.
speth
force-pushed
the
native-hdf5
branch
3 times, most recently
from
32d4818 to
b0d9a8c
Compare
ischoegl
approved these changes
Jun 29, 2023
Member
ischoegl
left a comment
ischoegl
left a comment
There was a problem hiding this comment.
This looks good to me, with the caveat that I'm not super-experienced with recipes. I'll defer to @bryanwweber, but am approving anyways.
bryanwweber
approved these changes
Jun 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExtensibleRateimplementations from programs linking to the Cantera shared library as part of the corresponding version of the Python module.Fixes #43
See CI status here: https://github.com/speth/conda-recipes/actions/workflows/main.yml