Skip to content

Create GitHub actions workflow#22

Closed
bryanwweber wants to merge 4 commits intomasterfrom
add-github-actions
Closed

Create GitHub actions workflow#22
bryanwweber wants to merge 4 commits intomasterfrom
add-github-actions

Conversation

@bryanwweber
Copy link
Copy Markdown
Member

@bryanwweber bryanwweber commented Feb 12, 2020

Try to build the Python and libcantera recipes. Check how environment variables work across steps.

@bryanwweber bryanwweber mentioned this pull request Feb 22, 2020
Closed
20 tasks
@bryanwweber
Copy link
Copy Markdown
Member Author

bryanwweber commented Feb 23, 2020

Currently the Windows builds are failing due to a linker error that's not showing up in the logs. This may require local debugging.

@bryanwweber
Copy link
Copy Markdown
Member Author

bryanwweber commented Jun 30, 2020 •
edited
Loading

The problem with the linker on Windows can be resolved by forcing the vs2017_win-64 package to be version 19.15.* instead of 19.16.* (the latter version was released in mid-2019, which is when the builds started failing). The version can be forced by setting vs2017_win-64 ==19.15.* in the meta.yaml/requirements/build sections. The .* on the end is important.

The problem appears to be some sort of conflict with how MSVC environment variables are added to the shell and how SCons wants them to be. The activation script for the 19.16 version is somewhat more complicated, because it appears to handle the case of MSVC 14.1 installed in VS 2019. My guess at the line that is making the difference is a change from:

:: Working
pushd "%VSINSTALLDIR%" 
CALL "VC\Auxiliary\Build\vcvars64.bat" 
popd

to

:: Not Working
pushd %VSINSTALLDIR%
CALL "VC\Auxiliary\Build\vcvars%BITS%.bat" -vcvars_ver=14.16 %WindowsSDKVer%
popd

Specifically, the addition of the -vcvars_ver argument to the script. Just a guess for now though.

@bryanwweber
Copy link
Copy Markdown
Member Author

bryanwweber commented Jun 30, 2020

Everything passed here, so I'll squash the commits, remove Travis and Appveyor, and merge this unless there are any concerns

@bryanwweber
Fix compilers on Windows
62c0ef0 
The 19.16 version of the vs2017_win-64 package breaks the builds on
Windows. The reason is not totally clear, but is possibly related to how
the vcvars64.bat script is called, where the 19.16 version of the
package adds an argument to specify the toolset version. This ends up
causing SCons to be unable to link the library together after everything
builds. SCons throws a "file not found" error, even though the files are
clearly there. I suspect that there's a version mismatch somewhere with
the different MSVC parts and how Conda and SCons each set them up.

The resolution is to fix the vs2017_win-64 package to the 19.15 version.
This results in warnings about using the old method for specifying
compilers in conda-build, which (according to the message) will be
removed after conda-build 4.0. C'est la vie, we'll deal with it then.

Also, remove ruamel_yaml as a build-time dependency, due to changes in
the main Cantera branch.
@bryanwweber bryanwweber force-pushed the add-github-actions branch from d198b72 to 338400d Compare July 1, 2020 02:43
@bryanwweber bryanwweber force-pushed the add-github-actions branch from 338400d to 75f500c Compare July 1, 2020 02:45
@bryanwweber
Change CI to GitHub Actions
75b4651 
For many of the same reasons as the change at the main repo (see
Cantera/cantera#775), this commit changes the CI to use GitHub actions
instead of Travis CI and Appveyor.
@bryanwweber
Remove Windows 32-bit builds entirely
fa0bf65 
The code was commented out anyways, so it can be deleted and resurrected
from the git history if necessary.
@bryanwweber bryanwweber force-pushed the add-github-actions branch from 75f500c to fa0bf65 Compare July 1, 2020 02:55
@bryanwweber
Copy link
Copy Markdown
Member Author

bryanwweber commented Jul 1, 2020

Merged into the main branch.

@bryanwweber bryanwweber closed this Jul 1, 2020
@bryanwweber bryanwweber deleted the add-github-actions branch November 29, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bryanwweber @speth