Handle species thermo temperature limits, and minor fixes#970
Merged
speth merged 7 commits intoCantera:mainfrom Jan 30, 2021
Merged
Handle species thermo temperature limits, and minor fixes#970speth merged 7 commits intoCantera:mainfrom
speth merged 7 commits intoCantera:mainfrom
Conversation
Corresponds to fix applied in Cantera/cantera-website#116
Completes update started in f5f12ca
Prefer the more specific files nasa_gas.yaml and nasa_condensed.yaml
For the constant-cp (ConstCpPoly) and piecewise-gibbs (Mu0Poly) species thermo models, the default min and max temperature were both zero. Because Cantera rarely checks these temperature bounds, use of these defaults is fine in most cases, but causes confusing errors on the rare occasions where the bounds are accessed, as in the "gibbs" (MultiPhase) equilibrium solver. Setting the default max temperature to infinity avoids these confusing errors without introducing an arbitrary default value or the requirement to always specify temperature limits.
Codecov Report
@@ Coverage Diff @@
## main #970 +/- ##
==========================================
+ Coverage 71.26% 71.28% +0.02%
==========================================
Files 377 377
Lines 46301 46335 +34
==========================================
+ Hits 32995 33032 +37
+ Misses 13306 13303 -3
Continue to review full report at Codecov.
|
bryanwweber
approved these changes
Jan 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
constant-cpandpiecewise-Gibbsspecies thermo to infinity (instead of 0)nasa.yaml, in favor of the more specificnasa_gas.yamlandnasa_condensed.yamlfilesChecklist
scons build&scons test) and unit tests address code coverage