Skip to content

[samples] Fix cxx demo and add sample to test suite#927

Merged
speth merged 1 commit intoCantera:mainfrom
ischoegl:cxx-demo
Sep 4, 2020
Merged

[samples] Fix cxx demo and add sample to test suite#927
speth merged 1 commit intoCantera:mainfrom
ischoegl:cxx-demo

Conversation

@ischoegl
Copy link
Copy Markdown
Member

@ischoegl ischoegl commented Sep 2, 2020 •
edited
Loading

Changes proposed in this pull request

  • fix cxx demo sample
  • add sample compilation to scons samples
  • add sample to test suite scons test-cxx-demo

If applicable, fill in the issue number this pull request is fixing

Fixes #926

Checklist

  • There is a clear use-case for this code change
  • The commit message has a short title & references relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • The pull request is ready for review

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 2, 2020 •
edited
Loading

Codecov Report

Merging #927 into main will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #927      +/-   ##
==========================================
+ Coverage   71.19%   71.21%   +0.02%     
==========================================
  Files         376      377       +1     
  Lines       46218    46259      +41     
==========================================
+ Hits        32903    32942      +39     
- Misses      13315    13317       +2
Impacted Files Coverage Δ
samples/cxx/demo/demo.cpp 95.12% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95387d3...b6a57f2. Read the comment docs.

@ischoegl ischoegl mentioned this pull request Sep 2, 2020
Merged
@ischoegl
Copy link
Copy Markdown
Member Author

ischoegl commented Sep 4, 2020 •
edited
Loading

@speth / @bryanwweber ... this probably should be added before 2.5. The actual 'fix' involves a single line ...

@speth speth merged commit 986f44b into Cantera:main Sep 4, 2020
@ischoegl ischoegl deleted the cxx-demo branch September 5, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@speth speth speth approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cxx demo sample is broken

2 participants

@ischoegl @speth