Skip to content

Minor reactor example updates#876

Merged
speth merged 5 commits intoCantera:mainfrom
ischoegl:tweak-examples
Jul 27, 2020
Merged

Minor reactor example updates#876
speth merged 5 commits intoCantera:mainfrom
ischoegl:tweak-examples

Conversation

@ischoegl
Copy link
Copy Markdown
Member

@ischoegl ischoegl commented Jun 21, 2020 •
edited
Loading

Checklist

  • There is a clear use-case for this code change
  • The commit message has a short title & references relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • The pull request is ready for review

If applicable, fill in the issue number this pull request is fixing

Fixes #875

Changes proposed in this pull request

  • Use recently implemented methods to simplify examples
  • Small fixes

PS: The broken AppVeyor build appears to be unrelated to changes in this PR, see #878.

@ischoegl ischoegl mentioned this pull request Jun 21, 2020
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 24, 2020 •
edited
Loading

Codecov Report

Merging #876 into main will decrease coverage by 0.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #876      +/-   ##
==========================================
- Coverage   71.56%   71.11%   -0.45%     
==========================================
  Files         372      376       +4     
  Lines       44510    46201    +1691     
==========================================
+ Hits        31853    32858    +1005     
- Misses      12657    13343     +686
Impacted Files Coverage Δ
include/cantera/cython/funcWrapper.h 43.47% <0.00%> (-39.14%) ⬇️
src/numerics/FuncEval.cpp 44.82% <0.00%> (-6.90%) ⬇️
include/cantera/zeroD/Wall.h 44.44% <0.00%> (-5.56%) ⬇️
src/thermo/IonsFromNeutralVPSSTP.cpp 40.11% <0.00%> (-3.17%) ⬇️
src/thermo/IdealSolnGasVPSS.cpp 68.71% <0.00%> (-2.63%) ⬇️
src/numerics/CVodesIntegrator.cpp 74.59% <0.00%> (-2.46%) ⬇️
src/zeroD/flowControllers.cpp 89.74% <0.00%> (-2.37%) ⬇️
include/cantera/thermo/ConstDensityThermo.h 7.50% <0.00%> (-2.26%) ⬇️
src/transport/TransportFactory.cpp 98.21% <0.00%> (-1.79%) ⬇️
src/zeroD/ConstPressureReactor.cpp 64.93% <0.00%> (-1.74%) ⬇️
... and 184 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64924d2...edfa4c1. Read the comment docs.

bryanwweber
bryanwweber requested changes Jun 27, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@bryanwweber bryanwweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ischoegl! These updates look good, with just one small comment below.

@speth speth changed the base branch from master to main June 30, 2020 23:15
@ischoegl
Copy link
Copy Markdown
Member Author

ischoegl commented Jul 8, 2020

Adding another minor example fix, as I'm not sure about the fate of #892 (which is where it was found originally)

@ischoegl ischoegl mentioned this pull request Jul 9, 2020
Closed
4 tasks
@bryanwweber bryanwweber mentioned this pull request Jul 23, 2020
Closed
speth
speth approved these changes Jul 27, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure that the use of add_species_alias in these examples adds any clarity, but having a couple of examples that at least show one way that this function can be used is somewhat useful.

The other changes are all good, of course.

@speth speth merged commit cfc9623 into Cantera:main Jul 27, 2020
@ischoegl ischoegl deleted the tweak-examples branch September 3, 2020 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@speth speth speth approved these changes

@bryanwweber bryanwweber bryanwweber approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Broken piston.py example

3 participants

@ischoegl @speth @bryanwweber