Conversation
|
Also see 2f8f685 😉 |
|
@bryanwweber ... the commit I referenced is part of #805, which is awaiting review. I stumbled across this while working on #805 and submitted an issue then. I don't have a problem with @sin-ha's resolution, as it is virtually identical (#805 does depend on slicable SolutionArrays though, so the fix should be applied first in whichever way). |
|
hey, @ischoegl @bryanwweber I am eager to work on related problems can you guide me? on #805 |
|
@sin-ha ... pull request #805 is currently awaiting review by one of the developers, so there's nothing to do there apart from reviewing. For things to work on, the issue tracker is a good start. Look for open issues that do not have a linked pull request yet (you should see an icon on the overview; linked pull requests contain proposed fixes). You probably already read through the contributor's guide. |
Codecov Report
@@ Coverage Diff @@
## master #816 +/- ##
=======================================
Coverage 71.39% 71.39%
=======================================
Files 372 372
Lines 43482 43482
=======================================
Hits 31045 31045
Misses 12437 12437 Continue to review full report at Codecov.
|
Checklist
scons build&scons test) and unit tests address code coverageIf applicable, fill in the issue number this pull request is fixing
Fixes #804
The changes allow list slicing in SolutionArray
Changes proposed in this pull request
-Changes to accommodate list slicing by making two cases of the SolutionArray