Merged
Conversation
Further: * rename Inlet1D.h to Boundary1D.h * rename boundaries1D.cpp to Boundary1D.cpp
Re-add Inlet1D to define Brdy1D; deprecation warnings are issued for both. The separate commit should keep the diff smaller.
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #815 +/- ##
==========================================
- Coverage 71.39% 71.37% -0.02%
==========================================
Files 372 372
Lines 43482 43482
==========================================
- Hits 31045 31037 -8
- Misses 12437 12445 +8
Continue to review full report at Codecov.
|
speth
approved these changes
Jun 5, 2020
Member
speth
left a comment
speth
left a comment
There was a problem hiding this comment.
This seems straightforward enough to me. While there are lots of little naming warts throughout Cantera, this one was especially messy, and is worth cleaning up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
scons build&scons test) and unit tests address code coverageIf applicable, fill in the issue number this pull request is fixing
Resolves “small” project idea (see 1D Flame Development Ideas):
Changes proposed in this pull request
While the
Boundary1D.hdiff does not show a good overview, individual commits do:Brdy1DtoBoundary1D, etc.),doublerealbydouble; since entire files are renamed, I felt like this was an appropriate occasion).