Conversation
Fix the reaction equation to always include the (+M). Previously, if the (+M) was omitted, an invalid reaction string was generated.
Codecov Report
@@ Coverage Diff @@
## master #708 +/- ##
==========================================
+ Coverage 70.63% 70.64% +0.01%
==========================================
Files 372 372
Lines 43567 43567
==========================================
+ Hits 30773 30778 +5
+ Misses 12794 12789 -5
Continue to review full report at Codecov.
|
bryanwweber
left a comment
bryanwweber
left a comment
There was a problem hiding this comment.
Other than the one comment below, this all seems fine. Any reason not to use this to refactor the CTML tests too? I'm also asking because I'm wondering if I should use it for the ctml2yaml tests.
| from cantera import ck2cti, cti2yaml | ||
| from cantera import ck2cti, ck2yaml, cti2yaml | ||
|
|
||
| class converterTestCommon: |
There was a problem hiding this comment.
I was going to suggest using pathlib here, to move away from string manipulation for paths, but I'm not sure it's worth it. Since the converter functions don't work with path-types, it night as well just still be string stuff...
What do you mean by "the CTML tests"? The refactoring here is fairly easy since in both cases you're going from CK format to something that can be imported as a |
2 participants
The test suite re-uses the tests for ck2cti.
Also fix a few small issues identified by running the tests.