[cti2yaml] Add failing ch4_ion test#707
Merged
bryanwweber merged 3 commits intoCantera:masterfrom Nov 2, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #707 +/- ##
==========================================
+ Coverage 70.63% 70.85% +0.21%
==========================================
Files 372 374 +2
Lines 43567 43668 +101
==========================================
+ Hits 30773 30939 +166
+ Misses 12794 12729 -65
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
ch4_ion.ctito YAML format. The test fails because the phase option'skip_undeclared_third_bodies'is not handledJust documenting this failure here so I don't forget while working on the
ctml2yaml, and also to ask whether this is expected or not. Someone else can work up a fix if they want, or I'll get to it in a bit.