Add yaml-cpp to the shared libraries if building with system yaml-cpp#671
Add yaml-cpp to the shared libraries if building with system yaml-cpp#671speth merged 3 commits intoCantera:masterfrom spinnau:fix-668
Conversation
Codecov Report
@@ Coverage Diff @@
## master #671 +/- ##
==========================================
+ Coverage 70.78% 70.78% +<.01%
==========================================
Files 373 373
Lines 43454 43454
==========================================
+ Hits 30757 30758 +1
+ Misses 12697 12696 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #671 +/- ##
==========================================
+ Coverage 70.66% 70.78% +0.11%
==========================================
Files 372 373 +1
Lines 43507 43454 -53
==========================================
+ Hits 30745 30758 +13
+ Misses 12762 12696 -66
Continue to review full report at Codecov.
|
|
I pushed a few more changes to fix the compiling issue I was having on macOS with @speth Can you take a look and verify that these changes are correct? |
|
@bryanwweber: Compiles and works fine for me on Linux with your changes and |
…-cpp If building Cantera with system_yamlcpp=y the yaml-cpp library needs to be specified in the linker flags. Fixes #668
Similar to the system_sundials option, libyaml-cpp must be added to the linker line when the system libraries are used.
We use the header-only version of fmt now, so no need to link to the compiled library.
3 participants
Fixes #668
Changes proposed in this pull request: