Add solvePseudoSteadyStateProblem() in cython interface#592
Merged
speth merged 5 commits intoCantera:masterfrom Feb 11, 2019
lavdwall:master
Merged
Add solvePseudoSteadyStateProblem() in cython interface#592speth merged 5 commits intoCantera:masterfrom lavdwall:master
speth merged 5 commits intoCantera:masterfrom
lavdwall:master
Conversation
Add solvePseudoSteadyStateProblem to cython interface
Add solvePseudoSteadyStateProblem to cython interface
speth
requested changes
Feb 7, 2019
Member
speth
left a comment
speth
left a comment
There was a problem hiding this comment.
The implementation looks good to me. I just have a small question about the docstring.
|
|
||
| def advance_coverages_to_steady_state(self): | ||
| """ | ||
| This method advances the surface coverages to (pseudo) steady state. |
Member
There was a problem hiding this comment.
I know this comes from the name of the underlying method, but can you either explain what "pseudo" means here, or remove it from the description, depending on what you think makes more sense?
Contributor
Author
There was a problem hiding this comment.
For me it is OK just to remove it from the description.
Member
There was a problem hiding this comment.
Can you push a revised version of the PR, then?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes my post in the Cantera Users' Group:
https://groups.google.com/d/msg/cantera-users/cZZXmLGPXaM/qpwBDh47GAAJ