Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #574 +/- ##
==========================================
+ Coverage 64.01% 64.05% +0.04%
==========================================
Files 388 388
Lines 41410 41476 +66
==========================================
+ Hits 26507 26566 +59
- Misses 14903 14910 +7
Continue to review full report at Codecov.
|
speth
requested changes
Dec 4, 2018
Member
speth
left a comment
There was a problem hiding this comment.
It looks like the implementation for reading the critical properties is more or less working, but I have some concerns about the current version of the property database.
Adds capability for RedlichKwongMFTP to read a database of critical properties for Tc and Pc of common species, so that users do not need to input pureFluidParameters for every single species, thereby reducing burden during creation of new cti files. For any species where pureFluidParameters are not provided by the user, function getCoeffs scans the database looking for matches. Any unmatched species will throw an error. Currently only scans by species name string, and is only intended for common species with well-known critical properties. Current operation is quite slow if the table is consulted for a large number of species. In the future, should also implement the capability to write the updated pureFluidParameters back into the xml file, so the user only has to perform the lookup once.
5abaf52 to
7d782df
Compare
speth
approved these changes
Dec 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This supercedes #464