Deprecate various unused / redundant functions#2044
Merged
speth merged 12 commits intoCantera:mainfrom Nov 14, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2044 +/- ##
==========================================
- Coverage 76.41% 76.40% -0.01%
==========================================
Files 463 463
Lines 54952 54954 +2
Branches 9308 9308
==========================================
- Hits 41990 41988 -2
- Misses 9831 9834 +3
- Partials 3131 3132 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Deprecating some methods that are either redundant or rarely if ever used. Deleting a couple of unused internal methods. Specifically
WaterPropsIAPWS::corr1methodWaterPropsIAPWS:density_const,densSpinodalWater,densSpinodalSteam.MixtureFugacityTP::densSpinodalLiquidanddensSpinodalGasThermoPhase::getPureGibbsmethod which mirrorsgetStandardChemPotentialsKinetics::getActivityConcentrations-- these should be accessed viaThermoPhasenewReaction(string)constructor for creating "empty" reactions.BandMatrixandDenseMatrixadd_module_directoryandimport_phasesChecklist
scons build&scons test) and unit tests address code coverage