Skip to content

Remove matlab ignite.m sample#2040

Merged
speth merged 1 commit intoCantera:mainfrom
ischoegl:remove-matlab-ignite
Nov 11, 2025
Merged

Remove matlab ignite.m sample#2040
speth merged 1 commit intoCantera:mainfrom
ischoegl:remove-matlab-ignite

Conversation

@ischoegl
Copy link
Copy Markdown
Member

@ischoegl ischoegl commented Nov 11, 2025

Changes proposed in this pull request

  • Remove ignite.m sample per discussion in MATLAB's ignite sample fails #2033
  • Replace most instances of 'Matlab' with 'MATLAB' in documentation (in accordance with MathWorks' usage)

If applicable, fill in the issue number this pull request is fixing

Closes #2033

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@ischoegl ischoegl force-pushed the remove-matlab-ignite branch from db3be98 to a8bc54c Compare November 11, 2025 12:08
@ischoegl ischoegl marked this pull request as ready for review November 11, 2025 13:13
@ischoegl ischoegl requested a review from a team November 11, 2025 13:13
@speth
Copy link
Copy Markdown
Member

speth commented Nov 11, 2025

Replace most instances of 'Matlab' with 'MATLAB' in documentation (in accordance with MathWorks' usage)

While MathWorks may want this, I don't. I don't think companies should get to decide that their name is so important that YOU HAVE TO SHOUT IT. "Matlab" isn't really an acronym, and so doesn't warrant that styling. I'd consider "MatLab" given the etymology as "matrix laboratory", but that seems to be rarely used.

@ischoegl ischoegl force-pushed the remove-matlab-ignite branch from a8bc54c to 95aa0c9 Compare November 11, 2025 14:41
@ischoegl
Copy link
Copy Markdown
Member Author

While MathWorks may want this, I don't.

While I'm in favor of canonical usage of terms, this is ultimately a minor nit. I just dropped the commit.

@speth speth merged commit 61d5c5b into Cantera:main Nov 11, 2025
61 checks passed
@ischoegl ischoegl deleted the remove-matlab-ignite branch November 17, 2025 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MATLAB's ignite sample fails

2 participants