Fix corner cases in installation process#2039
Merged
ischoegl merged 7 commits intoCantera:mainfrom Nov 14, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2039 +/- ##
=======================================
Coverage 76.41% 76.41%
=======================================
Files 463 463
Lines 54952 54952
Branches 9308 9308
=======================================
Hits 41990 41990
Misses 9831 9831
Partials 3131 3131 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Nov 11, 2025
Reflects setuptools 75.3.1 change to enforce lowercase package names. This change only affects Linux and other OSes with fully case-sensitive filesystems. macOS and Windows would see the build artifact as existing even though the capitalization was different.
Also eliminate extra 'html' subdirectory in install destination
speth
force-pushed
the
build-install-fixups
branch
from
a9629a9 to
415bd06
Compare
ischoegl
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
sphinx_docs=yis specified viacantera.confscons installafter previously runningscons doxygen sphinx(as opposed to using the stickysphinx_docs=y and doxygen_docs=yoptions)-isystem /usrto pkg-config compiler flags, which can break the compilationscons installIf applicable, fill in the issue number this pull request is fixing
sphinx_docsoption enabled #1871Checklist
scons build&scons test) and unit tests address code coverage