Skip to content

Add .NET examples to documentation / update docs#2027

Merged
speth merged 7 commits intoCantera:mainfrom
ischoegl:some-doc-updates
Nov 3, 2025
Merged

Add .NET examples to documentation / update docs#2027
speth merged 7 commits intoCantera:mainfrom
ischoegl:some-doc-updates

Conversation

@ischoegl
Copy link
Copy Markdown
Member

@ischoegl ischoegl commented Oct 31, 2025

Changes proposed in this pull request

  • Add .NET samples to Sphinx documentation and update reference
  • Update MATLAB reference

If applicable, fill in the issue number this pull request is fixing

Closes #2025, closes #2022

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@ischoegl ischoegl marked this pull request as draft October 31, 2025 13:48
Renamed for documentation purposes, specifically Sphinx-gallery.
While Program.cs is the conventional name for the application's entry
point, the compiler doesn't care.
@ischoegl ischoegl changed the title Add .NET examples to documentation Add .NET examples to documentation / update docs Oct 31, 2025
@ischoegl ischoegl marked this pull request as ready for review October 31, 2025 18:24
@ischoegl ischoegl requested a review from a team October 31, 2025 18:24
Copy link
Copy Markdown
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ischoegl. Just a couple of minor comments.

Comment on lines +1 to +4
.NET Examples
=============

Examples illustrating Cantera's .NET API are written in C#.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little unclear on how we want to label these examples. Are they "C# examples", or ".NET examples"? Maybe @burkenyo can weigh in on what the right terminology is here.

Copy link
Copy Markdown
Member Author

@ischoegl ischoegl Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went back and forth on this and settled on .NET for the API, and C# for the language (which I believe was the intent). The examples are C# as we're not providing the csproj files in the links.

@ischoegl ischoegl requested a review from speth November 2, 2025 16:11
@ischoegl
Copy link
Copy Markdown
Member Author

ischoegl commented Nov 3, 2025

@speth ... I feel fairly confident about the .NET terminology, as the examples are based on .NET project files. What is added to the gallery are only the C# files. Let me know if you have any other requests.

Copy link
Copy Markdown
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ischoegl. This looks good to me.

@speth speth merged commit 9970956 into Cantera:main Nov 3, 2025
54 checks passed
@ischoegl ischoegl deleted the some-doc-updates branch November 3, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.NET samples are not linked on website MATLAB docs need to be updated

2 participants