Skip to content

Fix intermittent CI failures and add Python 3.14 CI jobs#2012

Merged
speth merged 4 commits intoCantera:mainfrom
speth:fix-solver-ci-errors
Oct 21, 2025
Merged

Fix intermittent CI failures and add Python 3.14 CI jobs#2012
speth merged 4 commits intoCantera:mainfrom
speth:fix-solver-ci-errors

Conversation

@speth
Copy link
Copy Markdown
Member

@speth speth commented Oct 18, 2025 •
edited
Loading

Changes proposed in this pull request

  • Add CPU info printout for CI jobs that run examples from pre-compiled Cantera Python module
  • Use a better initial guess for surface coverages in catalytic_combustion.py to avoid occasional integration errors
  • Relax the default solution bounds for ionized species / electrons in 1D solver; these are still tighter than the tolerances for neutral species, but the severe limits on negative values created difficulties in finding acceptable damped steps that kept these components in bounds.
  • Add "normal" CI runs for Python 3.14. This includes some logic for skipping examples that depend on packages where installing from PyPI doesn't work.

If applicable, fill in the issue number this pull request is fixing

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@speth speth mentioned this pull request Oct 19, 2025
Closed
@speth speth force-pushed the fix-solver-ci-errors branch from f90a109 to 7ea66d4 Compare October 20, 2025 21:28
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 20, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.44%. Comparing base (5e351a1) to head (2d49030).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2012   +/-   ##
=======================================
  Coverage   75.43%   75.44%           
=======================================
  Files         454      454           
  Lines       56773    56773           
  Branches     9345     9345           
=======================================
+ Hits        42825    42830    +5     
+ Misses      10785    10780    -5     
  Partials     3163     3163

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@speth speth force-pushed the fix-solver-ci-errors branch 3 times, most recently from fa65902 to 01e6b50 Compare October 21, 2025 01:49
@speth speth changed the title WIP: Investigating CI failures Fix intermittent CI failures and add Python 3.14 CI jobs Oct 21, 2025
@speth speth added the CI label Oct 21, 2025
speth added 4 commits October 20, 2025 22:32
@speth
[CI] Print CPU info for jobs that only run tests
b91ad28
@speth
[Samples] Use better initial guess for surface coverages
d9d2083 
Fixes Cantera#1999
@speth
[1D] Relax default tolerances for ions / electrons
34d6a48 
Avoid solver failures even for cases where electric field is not being
solved due to difficult-to-meet tolerances.

Resolves Cantera#1991
@speth
[CI] Add standard jobs for Python 3.14
2d49030 
Add workaround to skip running examples for packages where PyPI doesn't
currently provide working installers.

Resolves Cantera#1994
@speth speth force-pushed the fix-solver-ci-errors branch from 01e6b50 to 2d49030 Compare October 21, 2025 02:32
@speth speth marked this pull request as ready for review October 21, 2025 14:48
@speth
Copy link
Copy Markdown
Member Author

speth commented Oct 21, 2025

I've re-run the CI several times. If this current attempt works, that will be 3 complete runs in a row without errors, which I would take as a good indicator that the intermittent failures are resolved.

ischoegl
ischoegl approved these changes Oct 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @speth - this all looks good to me!

@speth speth merged commit 457cb1f into Cantera:main Oct 21, 2025
147 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ischoegl ischoegl ischoegl approved these changes

Assignees

No one assigned

Labels

CI

Projects

None yet

Milestone

No milestone

2 participants

@speth @ischoegl