Conversation
7b234fd to
11771d3
Compare
7faedd0 to
8b2d606
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1993 +/- ##
==========================================
- Coverage 75.58% 75.43% -0.15%
==========================================
Files 451 454 +3
Lines 56369 56348 -21
Branches 9299 9299
==========================================
- Hits 42607 42508 -99
- Misses 10619 10698 +79
+ Partials 3143 3142 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e59069a to
7d84ef6
Compare
speth
left a comment
There was a problem hiding this comment.
Given that you've demonstrated that the same failures described in #1916 still occur on the macos-15-intel runner, I think this should be treated the same way, i.e. only run this as a post-merge test. Otherwise, we're going to keep seeing this error on unrelated PRs.
This could also be the right opportunity to drop the deprecated macos-13 runner that you've noted in #1992.
7d84ef6 to
f849f03
Compare
Done! |
|
Now we have an instance of this failure on the "macos-15-intel with Python 3.10" configuration, so it's not just related to Python 3.13: |
On the ‘upside’, the post-merge test that was supposed to fail is now running through! Looks like intel macs are now sporadically failing? |
c8eb2f9 to
28868a1
Compare
28868a1 to
0777a8c
Compare
|
@speth ... |
|
This failure of |
|
@speth ... correct (sorry but in all previous instances, the failures on this PR were from the post-merge tests). I had seen this one before, but curiously failing for the ion_flame example(!). For the last CI that was triggered, both previously failing macOS runners succeeded and this one failed. This PR's scope is to test macos-15-intel and address the removal of the macos-13 runners. |
| python-version: ${{ matrix.python-version }} | ||
| cache: pip | ||
| cache-dependency-path: requirements.txt | ||
| allow-prereleases: true |
There was a problem hiding this comment.
This is no longer needed, Python pi is official now 🎉
There was a problem hiding this comment.
Am aware. But it didn’t work this morning so I ended up adding this anyways.
Yes, of course. I commented just to make sure we don't lose information about this new failure mode. I didn't intend to suggest that this CI failure was a blocker for merging this PR. |
Changes proposed in this pull request
This PR is related to #1992 and testing for issue #1916
Issue Sporadic test failures on CI runners using macOS on Intel hardware #1916 cannot be reproduced onmacos-15-intel; with other tests by @speth failing to reproduce this locally, the only instance where sporadic failures are observed will not be reproducible anywhere once themacOS-13runner is removed.Initial testing indicates that intel hardware does not cause issues on macOS-15.Update: also replacing
macos-13runners.Closes #1992
Checklist
scons build&scons test) and unit tests address code coverage