Skip to content

Replace macos-13 runners#1993

Merged
speth merged 1 commit intoCantera:mainfrom
ischoegl:macos-15-intel
Oct 9, 2025
Merged

Replace macos-13 runners#1993
speth merged 1 commit intoCantera:mainfrom
ischoegl:macos-15-intel

Conversation

@ischoegl
Copy link
Copy Markdown
Member

@ischoegl ischoegl commented Oct 3, 2025

Changes proposed in this pull request

This PR is related to #1992 and testing for issue #1916

Update: also replacing macos-13 runners.

Closes #1992

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@ischoegl ischoegl added the CI label Oct 3, 2025
@ischoegl ischoegl added the macOS label Oct 3, 2025
@ischoegl ischoegl marked this pull request as ready for review October 3, 2025 10:48
@ischoegl ischoegl force-pushed the macos-15-intel branch 2 times, most recently from 7faedd0 to 8b2d606 Compare October 3, 2025 11:38
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.43%. Comparing base (96f98af) to head (0777a8c).
⚠️ Report is 43 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1993      +/-   ##
==========================================
- Coverage   75.58%   75.43%   -0.15%     
==========================================
  Files         451      454       +3     
  Lines       56369    56348      -21     
  Branches     9299     9299              
==========================================
- Hits        42607    42508      -99     
- Misses      10619    10698      +79     
+ Partials     3143     3142       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ischoegl ischoegl force-pushed the macos-15-intel branch 2 times, most recently from e59069a to 7d84ef6 Compare October 4, 2025 12:34
@ischoegl ischoegl requested a review from a team October 4, 2025 13:00
Copy link
Copy Markdown
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that you've demonstrated that the same failures described in #1916 still occur on the macos-15-intel runner, I think this should be treated the same way, i.e. only run this as a post-merge test. Otherwise, we're going to keep seeing this error on unrelated PRs.

This could also be the right opportunity to drop the deprecated macos-13 runner that you've noted in #1992.

@ischoegl
Copy link
Copy Markdown
Member Author

ischoegl commented Oct 6, 2025

This could also be the right opportunity to drop the deprecated macos-13 runner that you've noted in #1992.

Done!

@ischoegl ischoegl changed the title Test macos-15-intel runner Replace macos-13 runners Oct 6, 2025
@speth
Copy link
Copy Markdown
Member

speth commented Oct 6, 2025

Now we have an instance of this failure on the "macos-15-intel with Python 3.10" configuration, so it's not just related to Python 3.13:

[gw2] darwin -- Python 3.10.18 /Users/runner/hostedtoolcache/Python/3.10.18/x64/bin/python3
worker 'gw2' crashed while running 'test_reaction.py::TestBlowersMaselRate::test_derivative_ddT'

@ischoegl
Copy link
Copy Markdown
Member Author

ischoegl commented Oct 7, 2025

Now we have an instance of this failure on the "macos-15-intel with Python 3.10" configuration, so it's not just related to Python 3.13:

[gw2] darwin -- Python 3.10.18 /Users/runner/hostedtoolcache/Python/3.10.18/x64/bin/python3
worker 'gw2' crashed while running 'test_reaction.py::TestBlowersMaselRate::test_derivative_ddT'

On the ‘upside’, the post-merge test that was supposed to fail is now running through! Looks like intel macs are now sporadically failing?

@ischoegl ischoegl force-pushed the macos-15-intel branch 4 times, most recently from c8eb2f9 to 28868a1 Compare October 7, 2025 14:25
@ischoegl
Copy link
Copy Markdown
Member Author

ischoegl commented Oct 7, 2025

@speth ... thus far, we have exactly one of the jobs reliably fail, either 3.10 or 3.13; curiously, never both. Need to take this back ... after writing this, both succeeded, and a different job failed.

@speth
Copy link
Copy Markdown
Member

speth commented Oct 7, 2025

This failure of Run Python 3.10 examples on ubuntu-24.04, NumPy ==1.21.6 is different still, and not one I recall seeing before:

samples/python/onedim/catalytic_combustion.py
Traceback (most recent call last):
  File "/home/runner/work/cantera/cantera/samples/python/onedim/catalytic_combustion.py", line 68, in <module>
    surf_phase.advance_coverages(1.0)
  File "build/python/cantera/kinetics.pyx", line 943, in cantera.kinetics.InterfaceKinetics.advance_coverages
cantera._utils.CanteraError: 
*******************************************************************************
CanteraError thrown by CVodesIntegrator::integrate:
CVodes error encountered. Error code: -3
At t = 0.0583727 and h = 4.24999e-08, the error test failed repeatedly or with |h| = hmin.

Components with largest weighted error estimates:
4: -392.219827383851
9: 20.872449014364545
5: -0.0024577841850999837
1: -0.0002620613619660072
0: -0.00011714129027371423
2: -0.00011122842455574104
10: 9.99021834700569e-05
3: -5.6773903789372044e-05
7: -3.898277339646901e-157
8: -9.688141290158232e-158
*******************************************************************************

@ischoegl
Copy link
Copy Markdown
Member Author

ischoegl commented Oct 7, 2025

@speth ... correct (sorry but in all previous instances, the failures on this PR were from the post-merge tests). I had seen this one before, but curiously failing for the ion_flame example(!). For the last CI that was triggered, both previously failing macOS runners succeeded and this one failed. This PR's scope is to test macos-15-intel and address the removal of the macos-13 runners.

python-version: ${{ matrix.python-version }}
cache: pip
cache-dependency-path: requirements.txt
allow-prereleases: true
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer needed, Python pi is official now 🎉

Copy link
Copy Markdown
Member Author

@ischoegl ischoegl Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am aware. But it didn’t work this morning so I ended up adding this anyways.

@speth
Copy link
Copy Markdown
Member

speth commented Oct 8, 2025

@speth ... correct (sorry but in all previous instances, the failures on this PR were from the post-merge tests). I had seen this one before, but curiously failing for the ion_flame example(!). For the last CI that was triggered, both previously failing macOS runners succeeded and this one failed. This PR's scope is to test macos-15-intel and address the removal of the macos-13 runners.

Yes, of course. I commented just to make sure we don't lose information about this new failure mode. I didn't intend to suggest that this CI failure was a blocker for merging this PR.

@ischoegl ischoegl requested a review from speth October 9, 2025 13:35
@speth speth merged commit 3e99c4e into Cantera:main Oct 9, 2025
113 of 115 checks passed
@ischoegl ischoegl deleted the macos-15-intel branch October 9, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

macOS-13 GH runners to be retired

3 participants