Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1987 +/- ##
==========================================
- Coverage 75.58% 75.58% -0.01%
==========================================
Files 451 451
Lines 56362 56369 +7
Branches 9299 9299
==========================================
+ Hits 42602 42607 +5
- Misses 10616 10619 +3
+ Partials 3144 3143 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bryanwweber
reviewed
Sep 23, 2025
| [project] | ||
| name = "sourcegen" | ||
| version = "3.2.0a2" | ||
| version = "3.2.0a4" |
Member
There was a problem hiding this comment.
Somehow this got missed in the a2->a3 change too 😭
speth
requested changes
Sep 23, 2025
ischoegl
force-pushed
the
clib-paper-cuts
branch
from
71dc4e9 to
ce4782a
Compare
ischoegl
force-pushed
the
clib-paper-cuts
branch
from
ce4782a to
c70f197
Compare
Member
Author
|
@speth ... let me know if there's anything else. Otherwise, this is ready. |
speth
requested changes
Oct 1, 2025
Member
speth
left a comment
speth
left a comment
There was a problem hiding this comment.
Sorry for the delay. One more minor suggestion.
ischoegl
force-pushed
the
clib-paper-cuts
branch
from
c70f197 to
9b80155
Compare
speth
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Resolve remaining items marked as TODO in the generated CLib.
Checklist
scons build&scons test) and unit tests address code coverage