Skip to content

Update sdist and cibuildwheel configuration#1982

Merged
ischoegl merged 7 commits intoCantera:mainfrom
bryanwweber:bryan-update-sdist-config
Sep 19, 2025
Merged

Update sdist and cibuildwheel configuration#1982
ischoegl merged 7 commits intoCantera:mainfrom
bryanwweber:bryan-update-sdist-config

Conversation

@bryanwweber
Copy link
Copy Markdown
Member

@bryanwweber bryanwweber commented Sep 19, 2025

Changes proposed in this pull request

  • Updates to the sdist and cibuildwheel configuration to avoid building unsupported wheels
  • Updates to the sdist trove classifiers
  • Bump to 3.2.0a4 so we can test pushing this to PyPI

If applicable, fill in the issue number this pull request is fixing

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

This configuration ensures that cibuildwheel only tries to build 64-bit
wheels. This was pretty much the default anyways on our GHA builds, but
the explicit configuration just makes sure we don't introduce an
untested setup by accident.
@bryanwweber bryanwweber force-pushed the bryan-update-sdist-config branch from 382ddb2 to e1f7b13 Compare September 19, 2025 10:18
The builds for free-threading Python fail on Windows with the current
GHA infrastruture. I'm not sure why, and since we don't officially
support free-threading anyways, I'm not really inclined to debug it at
this time.
Update the dependency versions in the SDist configuration to match those
set up in the GHA build jobs and manylinux base image.
@bryanwweber bryanwweber force-pushed the bryan-update-sdist-config branch from e1f7b13 to b29dd11 Compare September 19, 2025 10:42
@bryanwweber bryanwweber changed the title Bryan update sdist config Update sdist and cibuildwheel configuration Sep 19, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.58%. Comparing base (72fbf27) to head (53f1791).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1982      +/-   ##
==========================================
+ Coverage   75.47%   75.58%   +0.11%     
==========================================
  Files         450      450              
  Lines       56317    56320       +3     
  Branches     9301     9294       -7     
==========================================
+ Hits        42503    42570      +67     
+ Misses      10680    10613      -67     
- Partials     3134     3137       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ischoegl
ischoegl previously approved these changes Sep 19, 2025
Copy link
Copy Markdown
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bryan. LGTM … as long as the (black?) reformatting isn’t trying to hide something 😂

@ischoegl ischoegl added compiling dependencies Pull requests that update a dependency file labels Sep 19, 2025
@bryanwweber
Copy link
Copy Markdown
Member Author

Thanks, @bryan. LGTM … as long as the (black?) reformatting isn’t trying to hide something 😂

Ruff, and oh no! I didn't mean for that to happen, thanks for pointing it out! I'll revert that

Copy link
Copy Markdown
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ischoegl ischoegl merged commit 3e83530 into Cantera:main Sep 19, 2025
51 checks passed
@bryanwweber bryanwweber deleted the bryan-update-sdist-config branch September 19, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiling dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants