Update sdist and cibuildwheel configuration#1982
Merged
ischoegl merged 7 commits intoCantera:mainfrom Sep 19, 2025
Merged
Conversation
This configuration ensures that cibuildwheel only tries to build 64-bit wheels. This was pretty much the default anyways on our GHA builds, but the explicit configuration just makes sure we don't introduce an untested setup by accident.
382ddb2 to
e1f7b13
Compare
The builds for free-threading Python fail on Windows with the current GHA infrastruture. I'm not sure why, and since we don't officially support free-threading anyways, I'm not really inclined to debug it at this time.
Update the dependency versions in the SDist configuration to match those set up in the GHA build jobs and manylinux base image.
e1f7b13 to
b29dd11
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1982 +/- ##
==========================================
+ Coverage 75.47% 75.58% +0.11%
==========================================
Files 450 450
Lines 56317 56320 +3
Branches 9301 9294 -7
==========================================
+ Hits 42503 42570 +67
+ Misses 10680 10613 -67
- Partials 3134 3137 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
Ruff, and oh no! I didn't mean for that to happen, thanks for pointing it out! I'll revert that |
b29dd11 to
53f1791
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
If applicable, fill in the issue number this pull request is fixing
Checklist
scons build&scons test) and unit tests address code coverage