Eliminate redundancy in Arrhenius / ArrheniusRate#1978
Merged
ischoegl merged 2 commits intoCantera:mainfrom Sep 17, 2025
Merged
Eliminate redundancy in Arrhenius / ArrheniusRate#1978ischoegl merged 2 commits intoCantera:mainfrom
ischoegl merged 2 commits intoCantera:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1978 +/- ##
==========================================
- Coverage 75.47% 75.46% -0.01%
==========================================
Files 450 450
Lines 56306 56315 +9
Branches 9301 9301
==========================================
+ Hits 42495 42500 +5
- Misses 10676 10680 +4
Partials 3135 3135 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
speth
force-pushed
the
fix-modify-Arrhenius
branch
from
25e8806 to
5013312
Compare
ischoegl
approved these changes
Sep 17, 2025
Member
ischoegl
left a comment
ischoegl
left a comment
There was a problem hiding this comment.
Thanks for eliminating this vestigial class, which was long overdue - I believe that removal was more complex at the time that ArrheniusRate was first introduced, but that has thankfully changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
ratemember of aReactionobject to work withArrheniusobjectsArrheniusclass in favor ofArrheniusRateIf applicable, fill in the issue number this pull request is fixing
Checklist
scons build&scons test) and unit tests address code coverage