Skip to content

Fix installation of generated CLib headers#1977

Merged
ischoegl merged 1 commit intoCantera:mainfrom
speth:fix-clib-install2
Sep 17, 2025
Merged

Fix installation of generated CLib headers#1977
ischoegl merged 1 commit intoCantera:mainfrom
speth:fix-clib-install2

Conversation

@speth
Copy link
Copy Markdown
Member

@speth speth commented Sep 15, 2025

Changes proposed in this pull request

  • Install headers for generated CLib
  • Exclude legacy CLib headers from installation when generated CLib is being used.

If applicable, fill in the issue number this pull request is fixing

Fixes (another) issue found while building conda-forge packages (see conda-forge/cantera-feedstock#63).

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

Exclude legacy CLib headers from installation when generated CLib
is being used.
@speth speth mentioned this pull request Sep 15, 2025
5 tasks
Copy link
Copy Markdown
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for identifying / fixing!

@ischoegl ischoegl merged commit b801cc3 into Cantera:main Sep 17, 2025
95 of 96 checks passed
@speth speth deleted the fix-clib-install2 branch September 17, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants