Skip to content

Update minimum CMake version in generated build scripts#1973

Merged
ischoegl merged 2 commits intoCantera:mainfrom
speth:update-cmake
Sep 11, 2025
Merged

Update minimum CMake version in generated build scripts#1973
ischoegl merged 2 commits intoCantera:mainfrom
speth:update-cmake

Conversation

@speth
Copy link
Copy Markdown
Member

@speth speth commented Sep 11, 2025

Changes proposed in this pull request

  • Update the minimum CMake version in generated CMakeLists.txt files. A minimum version of at least 3.5 is required to work with the current CMake version (3.31). I went higher than this for the sake of not having to update this for a good long while. 3.18 is the CMake version in Debian Bullseye, currently the "oldstable" release, so this shouldn't be much of a hurdle.
  • Fix the use of a deprecated version of MassFlowController.setTimeFunction in combustor.cpp.

If applicable, fill in the issue number this pull request is fixing

The first issue here is one of the problems currently preventing successful Conda package builds (see conda-forge/cantera-feedstock#63).

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

Copy link
Copy Markdown
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @speth!

@ischoegl ischoegl merged commit 33e5afc into Cantera:main Sep 11, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants