Use unicode superscript in Python docstrings / tweak pickle#1970
Merged
speth merged 4 commits intoCantera:mainfrom Sep 10, 2025
Merged
Use unicode superscript in Python docstrings / tweak pickle#1970speth merged 4 commits intoCantera:mainfrom
speth merged 4 commits intoCantera:mainfrom
Conversation
ischoegl
force-pushed
the
tweak-pickle
branch
from
457d96c to
1f2e037
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1970 +/- ##
=======================================
Coverage 75.46% 75.47%
=======================================
Files 450 450
Lines 56299 56306 +7
Branches 9301 9301
=======================================
+ Hits 42487 42495 +8
+ Misses 10677 10676 -1
Partials 3135 3135 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ischoegl
force-pushed
the
tweak-pickle
branch
from
1f2e037 to
fa23606
Compare
ischoegl
force-pushed
the
tweak-pickle
branch
5 times, most recently
from
11d94f8 to
ccaa97c
Compare
Member
Author
|
This is ready for a review - making sure |
speth
requested changes
Sep 9, 2025
Member
speth
left a comment
speth
left a comment
There was a problem hiding this comment.
Thanks for propagating this style update. I had just a couple of suggestions.
ischoegl
force-pushed
the
tweak-pickle
branch
from
ccaa97c to
7fef8ae
Compare
speth
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
SolutionandSolutionArrayfromNone(the latter would have caused a hard crash)As an aside: there could be an argument for typesetting units as math text, but that would result in a much larger scope/effort.
Checklist
scons build&scons test) and unit tests address code coverage