Deprecate ReactorBase::addThermo#1966
Merged
ischoegl merged 1 commit intoCantera:mainfrom Sep 7, 2025
Merged
Conversation
This method does not function as intended, since overrides are not executed when this method is called from the base class constructor. Derived classes needing customized behavior must implement it in their own constructors or in overrides of the initialize method.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1966 +/- ##
==========================================
- Coverage 75.04% 75.04% -0.01%
==========================================
Files 450 450
Lines 56237 56236 -1
Branches 9302 9302
==========================================
- Hits 42203 42201 -2
+ Misses 10901 10898 -3
- Partials 3133 3137 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The virtual
ReactorBase::addThermodoes not function as intended, since overrides are not executed when this method is called from the base class constructor. Derived classes needing customized behavior must implement it in their own constructors or in overrides of the initialize method.This erroneous usage was mostly invisible because we have only been using these overrides to ensure that the
ThermoPhaseobjects used in the "ideal gas" reactor types are in fact ideal gasses.Changes proposed in this pull request
ReactorBase::addThermoReactorBase::addThermoChecklist
scons build&scons test) and unit tests address code coverage