Fix synchronization of Reservoir state#1955
Merged
ischoegl merged 1 commit intoCantera:mainfrom Aug 25, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1955 +/- ##
=======================================
Coverage 74.98% 74.99%
=======================================
Files 450 450
Lines 56241 56237 -4
Branches 9300 9299 -1
=======================================
+ Hits 42174 42175 +1
+ Misses 10933 10930 -3
+ Partials 3134 3132 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1905
Changes proposed in this pull request
Fix synchronization of
Reservoirstate. While the reservoir itself has no governing equations, updating the state of its underlyingThermoPhaseobject can affect reactors linked by valves, walls, etc.If applicable, fill in the issue number this pull request is fixing
Closes #1905
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build&scons test) and unit tests address code coverage