Skip to content

Fix warnings printed in Python test suite#1946

Merged
ischoegl merged 3 commits intoCantera:mainfrom
speth:fix-test-warnings
Aug 23, 2025
Merged

Fix warnings printed in Python test suite#1946
ischoegl merged 3 commits intoCantera:mainfrom
speth:fix-test-warnings

Conversation

@speth
Copy link
Copy Markdown
Member

@speth speth commented Aug 15, 2025

Changes proposed in this pull request

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@speth speth added the tests Issues about tests, running the tests, or test results label Aug 15, 2025
@speth speth force-pushed the fix-test-warnings branch from 74b5254 to f5cc853 Compare August 16, 2025 22:13
speth added 3 commits August 22, 2025 10:50
@speth
[Input] Prevent warning about third-body duplicates when serializing
d7fcb71
@speth
[Numerics] Suppress SUNDIALS warning messages
d63f6fd 
Cantera already handles translating SUNDIALS errors into native exceptions,
so we don't want to also have SUNDIALS print error messages using its
default error handler.

The default error handler was an addition in SUNDIALS 7.0.
@speth
[Kinetics] Avoid division by 0 in BlowersMaselRate
037e4ae 
Fix test of sticking coefficient warnings
@speth speth force-pushed the fix-test-warnings branch from f5cc853 to 037e4ae Compare August 22, 2025 14:50
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 22, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.92%. Comparing base (376bf74) to head (037e4ae).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
include/cantera/kinetics/BlowersMaselRate.h 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1946   +/-   ##
=======================================
  Coverage   74.92%   74.92%           
=======================================
  Files         448      448           
  Lines       55757    55758    +1     
  Branches     9203     9204    +1     
=======================================
+ Hits        41775    41776    +1     
  Misses      10881    10881           
  Partials     3101     3101

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ischoegl
ischoegl approved these changes Aug 22, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @speth ... LGTM 🎉

@ischoegl ischoegl merged commit ff6a0c2 into Cantera:main Aug 23, 2025
91 of 95 checks passed
@speth speth deleted the fix-test-warnings branch August 23, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ischoegl ischoegl ischoegl approved these changes

Assignees

No one assigned

Labels

tests Issues about tests, running the tests, or test results

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Warnings clutter output of test_reactions.py

2 participants

@speth @ischoegl