Enforce utf8 encoding in sourcegen#1931
Merged
speth merged 2 commits intoCantera:mainfrom Jul 23, 2025
Merged
Conversation
ischoegl
force-pushed
the
sourcegen-encoding
branch
from
5871fc0 to
3d08812
Compare
Python 3.13.3, 3.13.4 and 3.13.5 show sporadic failures; see issue Cantera#1916
ischoegl
force-pushed
the
sourcegen-encoding
branch
from
0527dd1 to
6496597
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Unicode characters used in the documentation (e.g.,
²in units) cause failures on systems with different default encodings when CLib docstrings are regenerated; enforcingutf8resolves the issue.Also,
use Python 3.13.3disable Python 3.13 on macOS 13 to bypass issue #1916 so CLib tests are run.If applicable, fill in the issue number this pull request is fixing
Closes #1927
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build&scons test) and unit tests address code coverage