Update duplicate reactions when serializing#1923
Merged
speth merged 1 commit intoCantera:mainfrom Jul 9, 2025
Merged
Conversation
speth
force-pushed
the
fix-duplicate-serialization
branch
from
0bcd968 to
499076f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1923 +/- ##
=======================================
Coverage 74.87% 74.87%
=======================================
Files 448 448
Lines 55734 55740 +6
Branches 9192 9195 +3
=======================================
+ Hits 41730 41736 +6
Misses 10901 10901
Partials 3103 3103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
speth
force-pushed
the
fix-duplicate-serialization
branch
from
499076f to
c06e8af
Compare
5 tasks
speth
added a commit
to speth/cantera
that referenced
this pull request
Jul 11, 2025
Fixes some cases not handled correctly in Cantera#1923.
speth
added a commit
to speth/cantera
that referenced
this pull request
Jul 11, 2025
Fixes some cases not handled correctly in Cantera#1923.
speth
added a commit
to speth/cantera
that referenced
this pull request
Aug 24, 2025
Fixes some cases not handled correctly in Cantera#1923.
speth
added a commit
to speth/cantera
that referenced
this pull request
Aug 25, 2025
Fixes some cases not handled correctly in Cantera#1923.
speth
added a commit
to speth/cantera
that referenced
this pull request
Sep 23, 2025
Fixes some cases not handled correctly in Cantera#1923.
speth
added a commit
to speth/cantera
that referenced
this pull request
Sep 23, 2025
Fixes some cases not handled correctly in Cantera#1923.
speth
added a commit
to speth/cantera
that referenced
this pull request
Sep 23, 2025
Fixes some cases not handled correctly in Cantera#1923.
speth
added a commit
to speth/cantera
that referenced
this pull request
Sep 24, 2025
Fixes some cases not handled correctly in Cantera#1923.
speth
added a commit
to speth/cantera
that referenced
this pull request
Sep 29, 2025
Fixes some cases not handled correctly in Cantera#1923.
speth
added a commit
to speth/cantera
that referenced
this pull request
Sep 30, 2025
Fixes some cases not handled correctly in Cantera#1923.
speth
added a commit
to speth/cantera
that referenced
this pull request
Oct 1, 2025
Fixes some cases not handled correctly in Cantera#1923.
speth
added a commit
that referenced
this pull request
Oct 8, 2025
Fixes some cases not handled correctly in #1923.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
If applicable, fill in the issue number this pull request is fixing
Fixes #1922
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build&scons test) and unit tests address code coverage