Skip to content

Fix broken template variables building sdist#1919

Merged
bryanwweber merged 1 commit intoCantera:mainfrom
bryanwweber:bryan-fix-sdist-template
Jun 25, 2025
Merged

Fix broken template variables building sdist#1919
bryanwweber merged 1 commit intoCantera:mainfrom
bryanwweber:bryan-fix-sdist-template

Conversation

@bryanwweber
Copy link
Copy Markdown
Member

@bryanwweber bryanwweber commented Jun 25, 2025 •
edited
Loading

Changes proposed in this pull request

  • Fix incorrect template variables in the pyproject.toml.in for the sdist

Sorry for all the rework guys! Hopefully I got it right this time

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@bryanwweber bryanwweber requested a review from a team June 25, 2025 10:08
ischoegl
ischoegl approved these changes Jun 25, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Didn’t see any errors, but the nomenclature is a lot more consistent now. Of course something could be hiding in plain sight!

@bryanwweber bryanwweber merged commit 6a71ee7 into Cantera:main Jun 25, 2025
96 of 97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ischoegl ischoegl ischoegl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bryanwweber @ischoegl