Workaround for optimization bug in MSVC 17.14.36203.30#1913
Merged
speth merged 1 commit intoCantera:mainfrom Jun 21, 2025
Merged
Workaround for optimization bug in MSVC 17.14.36203.30#1913speth merged 1 commit intoCantera:mainfrom
speth merged 1 commit intoCantera:mainfrom
Conversation
Disable optimization of Windows builds until a fix for the below issue makes it into GitHub Actions runners. https://developercommunity.visualstudio.com/t/Code-optimization-bug-SIMD-std::vector/10912292
speth
force-pushed
the
msvc17.14-workaround
branch
from
a682fa9 to
c1c9eb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All MSVC CI builds are currently failing due to a recent update of the GitHub Actions runners to use Visual Studio 2022 version 17.14.36203.30 (updated from 17.13.35825.156; see here. This version has a bug in the code optimization which affects use of
std::transform. See the issue report here. The issues is already fixed upstream, but I don't know know how long that will take to filter down into a VS update followed by an update to the GitHub actions runners.Changes proposed in this pull request
Checklist
scons build&scons test) and unit tests address code coverage