Skip to content

Resolve some CI/build issues#1908

Merged
ischoegl merged 4 commits intoCantera:mainfrom
speth:ci-updates2
Jun 11, 2025
Merged

Resolve some CI/build issues#1908
ischoegl merged 4 commits intoCantera:mainfrom
speth:ci-updates2

Conversation

@speth
Copy link
Copy Markdown
Member

@speth speth commented Jun 11, 2025

Changes proposed in this pull request

  • Prevent CI builds using broken Cython version 3.1.2
  • Replace windows-2019 runners with windows-2025
  • Fix warnings about unused SUNDIALS callbacks
  • Fix warnings about license classifiers being deprecated

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.09%. Comparing base (b308592) to head (821763c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1908      +/-   ##
==========================================
- Coverage   74.10%   74.09%   -0.01%     
==========================================
  Files         444      444              
  Lines       55514    55514              
  Branches     9128     9126       -2     
==========================================
- Hits        41138    41135       -3     
- Misses      11285    11287       +2     
- Partials     3091     3092       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @speth!

@ischoegl ischoegl merged commit 52e63fe into Cantera:main Jun 11, 2025
51 checks passed
Copy link
Copy Markdown
Member

@bryanwweber bryanwweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of PR makes me wonder when it makes sense to have a requirements.txt for developer dependencies. Thanks for doing this!

@speth
Copy link
Copy Markdown
Member Author

speth commented Jun 11, 2025

This kind of PR makes me wonder when it makes sense to have a requirements.txt for developer dependencies.

I briefly started in this direction, but was dissuaded by a bunch of sources that suggested that requirements.txt is old and busted and that we ought to be using a pyproject.toml instead, and then thinking about the headache of doing that with something that isn't a Python project managed by one of the typical Python packaging systems.

@bryanwweber
Copy link
Copy Markdown
Member

My take is that requirements.txt is old and busted for use cases where you need to have consistent versioning, for library or application dependencies primarily. I agree pyproject.toml is not what we want. I think using requirements.txt for our case is more than appropriate and I'd be shocked if [uv] pip install -r stopped working any time in the near future. 🤷‍♂️

@ischoegl
Copy link
Copy Markdown
Member

ischoegl commented Jun 12, 2025

I don't have strong opinions, but believe that having a sufficiently spread-out test matrix on the CI should be adequate? (I'm not sure that all of us have to have the exact same toolchain.) As long as we test 3-4 versions plus bleeding edge on critical infrastructure we should be good. We mostly are already doing this ... the only one missing is the recent additional dependency on doxygen (which could be made optional if users don't care about CLib).

@bryanwweber
Copy link
Copy Markdown
Member

The idea for requirements.txt or similar would mostly help in defining package versions for CI. Instead of having to change every job when we need to change a version or add/remove a dependency, it'd be just one (or a few) file(s) that need to change.

bryanwweber added a commit to bryanwweber/cantera that referenced this pull request Jun 22, 2025
This version of Cython has a bug with respect to compiling multiple modules independently. It was fixed for CI in Cantera#1908 and this change also enforces the version requirement for the build systems.
ischoegl pushed a commit that referenced this pull request Jun 24, 2025
This version of Cython has a bug with respect to compiling multiple modules independently. It was fixed for CI in #1908 and this change also enforces the version requirement for the build systems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants