Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1908 +/- ##
==========================================
- Coverage 74.10% 74.09% -0.01%
==========================================
Files 444 444
Lines 55514 55514
Branches 9128 9126 -2
==========================================
- Hits 41138 41135 -3
- Misses 11285 11287 +2
- Partials 3091 3092 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bryanwweber
left a comment
There was a problem hiding this comment.
This kind of PR makes me wonder when it makes sense to have a requirements.txt for developer dependencies. Thanks for doing this!
I briefly started in this direction, but was dissuaded by a bunch of sources that suggested that requirements.txt is old and busted and that we ought to be using a pyproject.toml instead, and then thinking about the headache of doing that with something that isn't a Python project managed by one of the typical Python packaging systems. |
|
My take is that requirements.txt is old and busted for use cases where you need to have consistent versioning, for library or application dependencies primarily. I agree pyproject.toml is not what we want. I think using requirements.txt for our case is more than appropriate and I'd be shocked if |
|
I don't have strong opinions, but believe that having a sufficiently spread-out test matrix on the CI should be adequate? (I'm not sure that all of us have to have the exact same toolchain.) As long as we test 3-4 versions plus bleeding edge on critical infrastructure we should be good. We mostly are already doing this ... the only one missing is the recent additional dependency on doxygen (which could be made optional if users don't care about CLib). |
|
The idea for |
This version of Cython has a bug with respect to compiling multiple modules independently. It was fixed for CI in Cantera#1908 and this change also enforces the version requirement for the build systems.
This version of Cython has a bug with respect to compiling multiple modules independently. It was fixed for CI in #1908 and this change also enforces the version requirement for the build systems.
Changes proposed in this pull request
windows-2019runners withwindows-2025Checklist
scons build&scons test) and unit tests address code coverage