Codecov Report

Attention: Patch coverage is 70.73171% with 12 lines in your changes missing coverage. Please review.

Project coverage is 74.87%. Comparing base (284a989) to head (3e6ccd9).
Report is 43 commits behind head on main.

@@            Coverage Diff             @@
##             main    #1881      +/-   ##
==========================================
+ Coverage   74.28%   74.87%   +0.58%     
==========================================
  Files         448      448              
  Lines       55744    55734      -10     
  Branches     9190     9192       +2     
==========================================
+ Hits        41411    41730     +319     
+ Misses      11232    10901     -331     
- Partials     3101     3103       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ischoegl The second part of the unit test suite is ready for review. This will include tests for 0D classes. That leaves 1D classes to be the only part remaining, and these will come in a later PR as this one is also approaching 3000 lines.

All CIs will pass but there is one issue that throws warnings about already deleted objects:

*******************************************************************************
  CanteraError thrown by Cabinet::at:
  Object with index 5 has been deleted.
  *******************************************************************************
  
  
  Error in Solution/delete (line 98)
              ctFunc('soln_del', s.solnID);

This happens when an Interface class object is deleted in MATLAB, which calls the Solution class destructor, since Interface now inherits from Solution. Here's how the Interface constructor works:

First, it calls the soln_newInterface method in clib to create a new Interface object in SolutionCabinet.
ID = ctFunc('soln_newInterface', src, name, na, adj);

It then inherits methods and properties from the Solution class.
s@Solution(ID);

These steps should address this comment from #1665:

Both Interface and Solution are stored in the same SolutionCabinet, so the solnID should reference the correct object. You should not require interfaceID. I'm not sure how an object that should be correctly loaded in C++ ends up scrambled in clib? If there's an issue, it needs to be fixed in clib rather than having a workaround being created in MATLAB. Fwiw, Interface inherits from Solution in C++ and the same should be true in MATLAB (I believe there are technical reasons why it's implemented differently in Cython).

But for some reason, when the destructor is called, Cantera somehow thinks the object is already deleted, even though it isn't. Prior to invoking the destructor, all the methods of the Interface object could be called without problems. Any idea why this could happen?

@ssun30 … the changes in commit 258ce81 make me believe that #1898 may have been a MATLAB implementation issue after all. Could you verify?

@ssun30 … the changes in commit 258ce81 make me believe that #1898 may have been a MATLAB implementation issue after all. Could you verify?

That's correct. The soln_del method was called twice by the destructors of both Interface and Solution.