[C++] Provide const access to falloff rate parameters#1857
Merged
ischoegl merged 1 commit intoCantera:mainfrom Mar 12, 2025
Merged
[C++] Provide const access to falloff rate parameters#1857ischoegl merged 1 commit intoCantera:mainfrom
ischoegl merged 1 commit intoCantera:mainfrom
Conversation
A constant kinetics object cannot be used to obtain the Arrhenius parameters of falloff reactions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Currently, a constant kinetics object cannot be used to obtain the Arrhenius parameters of falloff reactions in the C++ interface without creating a copy of the reaction. Let's assume I need to access the Arrhenius parameters of a falloff reaction. I am working on a constant reference of the kinetics object:
To address this, constant variants of the
lowRate()andhighRate()member functions are added in this PR.scons build&scons test) and unit tests address code coverage