Skip to content

Sourcegen CLib edge cases#1846

Merged
speth merged 10 commits intoCantera:mainfrom
ischoegl:sourcegen-clib-edge
Mar 21, 2025
Merged

Sourcegen CLib edge cases#1846
speth merged 10 commits intoCantera:mainfrom
ischoegl:sourcegen-clib-edge

Conversation

@ischoegl
Copy link
Copy Markdown
Member

@ischoegl ischoegl commented Feb 3, 2025 •
edited
Loading

Changes proposed in this pull request

Address several edge cases encountered in CLib

  • Extend auto-generation of CLib APIs to variables (not just functions)
  • Use ReactionPathDiagram as an example (also, C++ API is updated to match Python API)
  • Expose Cantera constants to CLib
  • Implement CLib loggers

If applicable, fill in the issue number this pull request is fixing

Addresses Cantera/enhancements#220

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@ischoegl ischoegl added the clib label Feb 3, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 3, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.41667% with 19 lines in your changes missing coverage. Please review.

Project coverage is 74.39%. Comparing base (e6f3e9d) to head (fc7926b).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
src/kinetics/ReactionPath.cpp 59.45% 12 Missing and 3 partials ⚠️
interfaces/cython/cantera/reactionpath.pyx 63.63% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1846      +/-   ##
==========================================
- Coverage   74.41%   74.39%   -0.02%     
==========================================
  Files         386      386              
  Lines       53628    53651      +23     
  Branches     9063     9071       +8     
==========================================
+ Hits        39905    39913       +8     
- Misses      10652    10663      +11     
- Partials     3071     3075       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ischoegl ischoegl force-pushed the sourcegen-clib-edge branch 2 times, most recently from 3a2e8ec to 1597b38 Compare February 3, 2025 20:25
@ischoegl ischoegl mentioned this pull request Feb 3, 2025
Closed
9 tasks
@ischoegl ischoegl marked this pull request as ready for review February 3, 2025 20:51
@ischoegl ischoegl requested a review from a team February 3, 2025 20:51
@ischoegl ischoegl force-pushed the sourcegen-clib-edge branch from 1597b38 to dfec1b3 Compare February 3, 2025 21:30
speth
speth requested changes Feb 14, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ischoegl. This generally looks good to me. Just a few minor suggestions.

@ischoegl ischoegl force-pushed the sourcegen-clib-edge branch from bb81255 to fc7926b Compare February 15, 2025 02:16
@ischoegl
Copy link
Copy Markdown
Member Author

ischoegl commented Feb 15, 2025

@speth ... thanks for the review. The PR should be ready to merge.

@ischoegl ischoegl requested a review from speth February 16, 2025 02:42
@ischoegl
Copy link
Copy Markdown
Member Author

ischoegl commented Mar 9, 2025 •
edited
Loading

@speth ... this should be done/ready.

@speth speth mentioned this pull request Apr 25, 2023
Open
speth
speth approved these changes Mar 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ischoegl, these updates look good to me.

@speth speth merged commit a131160 into Cantera:main Mar 21, 2025
47 of 49 checks passed
@ischoegl ischoegl deleted the sourcegen-clib-edge branch March 21, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@speth speth speth approved these changes

Assignees

No one assigned

Labels

clib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ischoegl @speth