Skip to content

Remove deprecated code and update required dependency versions#1833

Merged
speth merged 14 commits intoCantera:mainfrom
speth:remove-deprecated
Dec 31, 2024
Merged

Remove deprecated code and update required dependency versions#1833
speth merged 14 commits intoCantera:mainfrom
speth:remove-deprecated

Conversation

@speth
Copy link
Copy Markdown
Member

@speth speth commented Dec 27, 2024

Changes proposed in this pull request

  • Bump development version to 3.2.0a1
  • Remove code that was deprecated in Cantera 3.1.0
  • Update minimum dependency versions, mainly in line with Ubuntu 22.04 LTS versions
    • Python >= 3.10
    • SUNDIALS >= 5.0
    • fmt >= 8.0
    • ruamel.yaml >= 0.17.16
    • numpy >=1.21
    • SCons >= 4.0
    • .NET >= 8.0
    • Visual Studio >= 2019 (toolset version >= 14.2)

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@speth speth force-pushed the remove-deprecated branch from 8b20b42 to fd5c913 Compare December 27, 2024 20:54
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 80.82192% with 14 lines in your changes missing coverage. Please review.

Project coverage is 74.42%. Comparing base (6e00275) to head (09d4343).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
interfaces/cython/cantera/ck2yaml.py 28.57% 5 Missing ⚠️
interfaces/cython/cantera/composite.py 0.00% 2 Missing ⚠️
src/clib/ctonedim.cpp 0.00% 2 Missing ⚠️
src/clib/ctreactor.cpp 0.00% 2 Missing ⚠️
src/numerics/CVodesIntegrator.cpp 94.73% 0 Missing and 1 partial ⚠️
src/zeroD/Reactor.cpp 0.00% 1 Missing ⚠️
src/zeroD/ReactorBase.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1833      +/-   ##
==========================================
+ Coverage   73.54%   74.42%   +0.87%     
==========================================
  Files         383      382       -1     
  Lines       54653    53410    -1243     
  Branches     9105     9026      -79     
==========================================
- Hits        40197    39749     -448     
+ Misses      11458    10615     -843     
- Partials     2998     3046      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@speth speth force-pushed the remove-deprecated branch 3 times, most recently from cc05f13 to 03cf00c Compare December 28, 2024 03:48
Copy link
Copy Markdown
Member

@bryanwweber bryanwweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for thanking this on Ray!

@speth speth force-pushed the remove-deprecated branch 2 times, most recently from b1534c4 to e11606d Compare December 30, 2024 16:23
@speth speth force-pushed the remove-deprecated branch from e11606d to 84ff613 Compare December 30, 2024 16:53
@speth speth force-pushed the remove-deprecated branch from 84ff613 to 09d4343 Compare December 30, 2024 17:46
@speth speth requested a review from a team December 30, 2024 19:21
Copy link
Copy Markdown
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @speth ... this all looks good from my side!

@speth speth merged commit 3d0c126 into Cantera:main Dec 31, 2024
@speth speth deleted the remove-deprecated branch December 31, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants