Fix SUNDIALS 7.x compatibility/library list checks#1828
Merged
speth merged 1 commit intoCantera:mainfrom Dec 16, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1828 +/- ##
==========================================
- Coverage 73.54% 73.54% -0.01%
==========================================
Files 383 383
Lines 54653 54653
Branches 9105 9105
==========================================
- Hits 40197 40194 -3
- Misses 11458 11460 +2
- Partials 2998 2999 +1 ☔ View full report in Codecov by Sentry. |
bryanwweber
approved these changes
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
sundials_coreis linked for SUNDIALS 7.0 and newer, and the warning about being untested only occurs for versions newer than 7.2.0.Checklist
scons build&scons test) and unit tests address code coverage