Prevent two-point control from finding solutions with reverse flow#1813
Merged
ischoegl merged 1 commit intoCantera:mainfrom Nov 16, 2024
Merged
Prevent two-point control from finding solutions with reverse flow#1813ischoegl merged 1 commit intoCantera:mainfrom
ischoegl merged 1 commit intoCantera:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1813 +/- ##
=======================================
Coverage 73.26% 73.26%
=======================================
Files 383 383
Lines 54620 54621 +1
Branches 9099 9099
=======================================
+ Hits 40016 40020 +4
+ Misses 11601 11599 -2
+ Partials 3003 3002 -1 ☔ View full report in Codecov by Sentry. |
ischoegl
approved these changes
Nov 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
If applicable, fill in the issue number this pull request is fixing
Fixes #1787
Checklist
scons build&scons test) and unit tests address code coverage